Using Kalendae from a dialog that is shown from a scrolled page #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e instantiate the calendar in a modal dialog (e.g. a Boostrap modal dialog) that is scrolled down the page)
|
Outside of a position:fixed element (which I'm assuming your popup window is), this change results in the popup appearing nowhere near the target input. I'll do some experimentation to see if I can address the issue you're having, but I'm afraid this pull request isn't usable in its current state. Just try it with the current index.html example file and you'll see what I mean. |
|
Gotcha. I've made a simple page to replicate this issue. https://github.com/ruckus/kalendae-modal-scroll-test The README contains some basic instructions on how to toggle correct / incorrect behavior. Please let me know if there is anything I can do. |
|
Bumped into this as well, would be great to have a fix! |
|
Looks like this was fixed in 20255ad Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am using Bootstrap and using the Modal dialog widget. Inside my widget I have a Kalendae object.
If I display a modal dialog box and the page is scrolled down than Kalendae does not properly calculate the
topposition because it doesnt factor in the amount the page is scrolled down.This pull request tweaks the
getPositionmethod and adds the scroll top to the final coordinates.